Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panorama not displayed with ignoreGPanoXMP=false #33

Closed
danielnaber opened this issue Jan 8, 2015 · 3 comments
Closed

panorama not displayed with ignoreGPanoXMP=false #33

danielnaber opened this issue Jan 8, 2015 · 3 comments

Comments

@danielnaber
Copy link
Contributor

Something seems to have been broken(?) by this commit: e90d65b. I cannot get a simple equirectangular panorama to display anymore after that change. My test tour is this:

{   
    "default": {
        "firstScene": "library"
    },

    "scenes": {
        "library": {
            "panorama": "R0010216-stacked.JPG"
        }        
    }
}

Instead of the image (which is loaded correctly according to Firebug), I only see a grey area. Setting ignoreGPanoXMP to true makes everything work again - so maybe the default should be set to true? I can send you the affected image by email if needed.

@mpetroff
Copy link
Owner

mpetroff commented Jan 8, 2015

I suspect the image contains XMP data. Looking back at my code, I'm trying to use the Google Panorama tags if an image has XMP data, whether or not it actually has the tags. Obviously, that ends badly when those XMP tags don't exist. I'll fix it tonight.

@mpetroff
Copy link
Owner

mpetroff commented Jan 8, 2015

I think I fixed it.

@danielnaber
Copy link
Contributor Author

I can confirm it's fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants