Allow displaying images and video in hotspots #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for using, (for example) fontawesome icons for hotspots
Meaning that the css keyword in json is replaced by a header keyword taking an html string as value. Example file updated accordingly
...but they don't really make sense content wise
mpetroff
added a commit
that referenced
this pull request
Aug 21, 2014
Allow displaying images and video in hotspots
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there :)
As previously discussed, I've added some capabilities to hotspots:
As a side effect, as I needed some icons to represent those in hotspots, I fiddled in the css to make it play a bit nicely (but not perfectly) with font-awesome.
As this is my first commit to pannellum, please feel free to correct whatever could be wrong, or to point me in the right direction... Thanks :)
Guillaume