Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay flags to libv4l2rtspserver target #13

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

didomenico
Copy link
Contributor

@didomenico didomenico commented Dec 5, 2023

Description

libv4l2rtspserver is built without using the compile flags of the Makefile.

Related Issue

#12

Motivation and Context

This change is needed to cross-compile libv4l2rtspserver using the liblibv4l2rtspserver.a target.
CXXFLAGS=-I[include_dir] CXX=[c++-compiler] CC=[c_compiler] make liblibv4l2rtspserver.a

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@@ -11,6 +11,7 @@ GSOAP_BIN?=$(GSOAP_PREFIX)/bin
GSOAP_BASE=$(GSOAP_PREFIX)/share/gsoap
GSOAP_PLUGINS=$(GSOAP_BASE)/plugin

CMAKE_CXX_FLAGS:=$(CXXFLAGS)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use it on libv4l2rtspserver cmake, the flags need to be copied before the hard coded values below are added to it.

@mpromonet
Copy link
Owner

Hi @didomenico

Thanks, looks good.

Best Regards,
Michel.

@mpromonet mpromonet merged commit a59b554 into mpromonet:master Dec 5, 2023
1 of 5 checks passed
@didomenico
Copy link
Contributor Author

didomenico commented Dec 6, 2023

Hi, @mpromonet,

Thank you.

Best regards,
William

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants