Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for validating version strings in various fields #9

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

mprpic
Copy link
Owner

@mprpic mprpic commented Mar 28, 2024

This implements a rudimentary check for valid version strings using a regular expression.

@mprpic
Copy link
Owner Author

mprpic commented Mar 28, 2024

@andrewpollock review appreciated 🙂

Copy link

@andrewpollock andrewpollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Awesome, you beat me to it :-)

internal/rules/affects.go Show resolved Hide resolved
@mprpic mprpic merged commit 934c66e into main Mar 29, 2024
@mprpic mprpic deleted the add-version-check branch March 29, 2024 19:02
@andrewpollock
Copy link

@mprpic can you make a new release to ship this functionality? I'm unsure how https://github.com/jgamblin/cvelint-action ticks...

@mprpic
Copy link
Owner Author

mprpic commented Apr 2, 2024

@mprpic can you make a new release to ship this functionality? I'm unsure how https://github.com/jgamblin/cvelint-action ticks...

Release is out: https://github.com/mprpic/cvelint/releases/tag/v0.3.0

But cvelint-action is pinned to v0.1.0; I submitted a PR to use always use the latest version: jgamblin/cvelint-action#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants