-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev 0.1.9.9999 #95
Merged
Merged
Dev 0.1.9.9999 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mps9506
commented
May 14, 2024
•
edited
Loading
edited
- change water api endpoint and values used in example (Fixes Examples returning empty dataframes #94)
- remove if/else that checks for number of records when returning sf dataframe. EPA removed this and should always return a geojson regardless of the number of records. (Fixes sdw endpoints are restricted to results <= 100,000 #93 )
- update mocked tests values
- update news, description, and version number
- adds covr workflow
- edit vignette and readme with new arguments and includes properly working spatial examples (fixes invalid GeoJSON #88 )
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.