Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the matched substring #97

Merged
merged 1 commit into from
Feb 5, 2016
Merged

Highlight the matched substring #97

merged 1 commit into from
Feb 5, 2016

Conversation

mptre
Copy link
Owner

@mptre mptre commented Jan 25, 2016

By using the underline capability the matched substring for all choices
is highlighted. This change gives a better notion of the actual match
and allows one to easily spot matched outliers.

The printing of choices is rewritten which removes the need to allocate
a new string for every matched choice and usage of two compat functions.

By using the underline capability the matched substring for all choices
is highlighted. This change gives a better notion of the actual match
and allows one to easily spot matched outliers.

The printing of choices is rewritten which removes the need to allocate
a new string for every matched choice and usage of two compat functions.
@calleluks
Copy link
Collaborator

@mptre Very cool! Those are amazing diff stats for an added feature. Works great on my machine. Let me take a closer look at the code on Friday.

@calleluks
Copy link
Collaborator

@mptre Sorry for taking so long. I've looked over the code and it looks great! I'll merge this.

@calleluks calleluks merged commit 6de1fe1 into mptre:master Feb 5, 2016
@mptre mptre deleted the underline branch February 5, 2016 10:30
@mptre
Copy link
Owner Author

mptre commented Feb 5, 2016

Great! Time for a proper release?

On Fri, Feb 05, 2016 at 02:08:03AM -0800, Calle Erlandsson wrote:

Merged #97.


Reply to this email directly or view it on GitHub:
#97 (comment)

@calleluks
Copy link
Collaborator

Yes, definitely! I'll use the current master for the coming week and then release next Friday.

I'm leaning on 1.3 for the version number. What are your thoughts?

@mptre
Copy link
Owner Author

mptre commented Feb 6, 2016

On Fri, Feb 05, 2016 at 07:32:07AM -0800, Calle Erlandsson wrote:

Yes, definitely! I'll use the current master for the coming week and then release next Friday.

I'm leaning on 1.3 for the version number. What are your thoughts?

None of the changes is breaking therefore 1.3 makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants