Add arrow key bindings #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a substantial change including several changes:
- Introducing a internal concept of lines in order to navigate the
input in two dimensions. The lines is represented as an array of
byte offsets where `lines.v[i]' represents the starting offset for
line `i - 1'.
- Solves input line counting problem by emitting the number of lines
and then storing the cursor position later used to restore the
cursor.
- Optimize the line counting by only examen at most
`tty.width*tty.height' bytes.
This was referenced Nov 7, 2015
|
Looks good! |
Instead of reading the offset from the given start pointer pass a offset argument instead.
Instead of moving the selection backwards until a intersecting field is found on the previous line start the search at the very start of the previous line. A pleasant side-effect of this behavior is that moving line wise is in both cases is a forward search.
Simplified detection of movement across lines.
|
Any bugs? Otherwise I'm planning on doing a release later this week. |
|
👍 worked for me |
This reverts commit 85f1101.
|
Released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing would be much appreciated. If you encounter a crash or any odd behavior please report back the input and steps necessary to reproduce the bug.