Control output binary name with PROG variable in the Makefile #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mptre
reviewed
Feb 17, 2017
Makefile
Outdated
| @@ -14,15 +16,15 @@ CPPFLAGS+= -DVERSION=\"${VERSION}\" -DYANKCMD=\"${YANKCMD}\" | |||
| all: yank | |||
mptre
reviewed
Feb 17, 2017
Makefile
Outdated
| @@ -14,15 +16,15 @@ CPPFLAGS+= -DVERSION=\"${VERSION}\" -DYANKCMD=\"${YANKCMD}\" | |||
| all: yank | |||
|
|
|||
| yank: yank.c | |||
mptre
reviewed
Feb 17, 2017
Makefile
Outdated
|
|
||
| clean: | ||
| rm yank | ||
| rm ${PROG} | ||
|
|
||
| install: yank |
|
Looks good! I've added some inline comments needed in order to not |
mptre
reviewed
Feb 17, 2017
Makefile
Outdated
| @@ -5,6 +5,8 @@ YANKCMD= xsel | |||
| PREFIX= /usr/local | |||
| MANPREFIX= ${PREFIX}/share/man | |||
|
|
|||
| PROG= yank | |||
There was a problem hiding this comment.
Indent with a single tab, not spaces.
mptre
reviewed
Feb 17, 2017
Makefile
Outdated
| @@ -14,15 +16,15 @@ CPPFLAGS+= -DVERSION=\"${VERSION}\" -DYANKCMD=\"${YANKCMD}\" | |||
| all: yank | |||
|
|
|||
| yank: yank.c | |||
| ${CC} ${CFLAGS} -o $@ $< ${LDFLAGS} ${CPPFLAGS} | |||
| ${CC} ${CFLAGS} -o ${PROG} $< ${LDFLAGS} ${CPPFLAGS} | |||
There was a problem hiding this comment.
Cange $< to yank.c. I'm running into to the following error when applying my
suggested changes:
Using $< in a non-suffix rule context is a GNUmake idiom (Makefile:19)
|
On it! Thanks for the comments. |
|
Done! Sorry, didn't know how "deep" I should go. Build works fine on Fedora 25 x86_64. Cheers! PS. Squashed again into one commit |
|
Thanks! Just released v0.8.1 including your changes. |
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #35