Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: set YANKCMD to pbcopy automagically on OSX #8

Closed
wants to merge 1 commit into from
Closed

Makefile: set YANKCMD to pbcopy automagically on OSX #8

wants to merge 1 commit into from

Conversation

stephenmathieson
Copy link

This way, OSX users can just make without having to remember to
specify YANKCMD=pbcopy.

This way, OSX users can just `make` without having to remember to
specify `YANKCMD=pbcopy`.
@mptre
Copy link
Owner

mptre commented Oct 15, 2015

Thanks for the contribution! I will however pass on this one. Incorporating
platform specific assumptions like this could possible spawn more requests to
add other platforms. Maintaining this kind of logic is not one of my top
priorities. This argument can however be questioned since YANKCMD defaults to
xsel. My only explanation is that I found it convenient at the time writing
this command. To solve this issue I added the YANKCMD variable and the --
option.

The preferred way to install yank on OS X will be using Homebrew in a nearby
future. Then you don't need to bother since it will be compiled with
YANKCMD=pbcopy.

On Wed, Oct 14, 2015 at 08:29:59AM -0700, Stephen Mathieson wrote:

This way, OSX users can just make without having to remember to
specify YANKCMD=pbcopy.
You can view, comment on, or merge this pull request online at:

#8

-- Commit Summary --

  • Makefile: set YANKCMD to pbcopy automagically on OSX

-- File Changes --

M Makefile (9)

-- Patch Links --

https://github.com/mptre/yank/pull/8.patch
https://github.com/mptre/yank/pull/8.diff


Reply to this email directly or view it on GitHub:
#8

@mptre mptre closed this Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants