Features/GitHub actions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to a release system that will trigger Dockerhub builds on release so we have a bit more separation and more appropriate pipeline to go from local changes to live site updates. Will need to migrate the DO App Platform settings to point to Dockerhub after this and a build is confirmed. In addition to Dockerhub builds I've also implemented gofmt and golangci-lint jobs in the GitHub Actions so we can get some formatting and linting going in this build pipeline. I also migrated the go.mod/go.sum files into their proper location inside the actual module and updated the settings so that things would work properly for that.
Moving to a release system that will trigger Dockerhub builds on release so we have a bit more separation and more appropriate pipeline to go from local changes to live site updates. Will need to migrate the DO App Platform settings to point to Dockerhub after this and a build is confirmed. In addition to Dockerhub builds I've also implemented gofmt and golangci-lint jobs in the GitHub Actions so we can get some formatting and linting going in this build pipeline. I also migrated the go.mod/go.sum files into their proper location inside the actual module and updated the settings so that things would work properly for that.
For some reason the golangci-linter doesn't actually output file/line info in the logs in the GitHub Action, which... what? You can get around this by specifying output tabbed apparently.
Mostly just not doing proper error checking on some of my functions. Main confusing thing was the pruner.go for loop. S1000 dictates that I should not use a select with a single use case and should instead just use a "simple channel send/receive" which basically just means if the channel I'm watching gets a message kick something off I guess. I'm really not entirely sure but it compiles and runs and golangci-lint is happy so w/e.
Apparently gofmt as a github action doesn't really do anything so removing that and I'll just add that to my local githook.
These are all changes from gofmt, so basically whitespace changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GitHub actions for linting/gofmting and building Docker images to Dockerhub. Also had to move some go related files around to enable things to work properly.