update to plotting_docs #10
Conversation
quickscreen/plot/plotter.py
Outdated
| """ | ||
| Function to save plot as jpg, only on MacOS | ||
| Hard Coded to save to the current working directory |
There was a problem hiding this comment.
recommend changing to just state "Saves to current working directory"
|
I see what you mean about pushing to someone's branch but at some point reviewing every change/accepting back-and-forth becomes bloat. Similar to when editing a document just saying "feel free to make changes required, don't bother doing them in tracked changes as I don't feel the need to review minor stuff". For more significant changes or things that are ambiguous or comments, I would agree but I think minor modifications (spelling changes, minor simple fixes, etc) shouldn't warrant the effort - aka don't make the comment, just make the minor change required.... definitely depends on the process deciding to work on though.... philosophical |
Changed some things
I couldnt get save location to work the way I wanted, so I removed that option
Made a PR because I was changing things that I wanted review on.
Also its pretty weird to
git pushto some one else's branch directly IMO