Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Polymer #41

Closed
gbisheimer opened this issue Dec 8, 2014 · 6 comments · Fixed by #42
Closed

Polymer #41

gbisheimer opened this issue Dec 8, 2014 · 6 comments · Fixed by #42
Labels

Comments

@gbisheimer
Copy link
Contributor

First of all, thanks you for this great package!

I'm having problems making this to work with Polymer components because Polymer's package name contains a slash in it ('Polymer/core-icons' for example), and your package is trying to import the files from the wrong path.

How can this package be used to install polymer and its related projects? Is there a workaround for this?

Thanks!

@gbisheimer
Copy link
Contributor Author

I was testing using the following bower.json file:

{
  "name": "my-app",
  "version": "0.0.0",
  "authors": [
    "Guillermo Bisheimer <gbisheimer@bys-control.com.ar>"
  ],
  "license": "MIT",
  "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "test",
    "tests"
  ],
  "dependencies": {
    "select2": "~3.5.2",
    "polymer": "~0.5.1",
    "webcomponents": "polymer/webcomponentsjs#~0.5.1"
  }
}

and meteor-bower fails to install webcomponents package.

@lorensr
Copy link
Collaborator

lorensr commented Dec 12, 2014

Same problem here.

@gbisheimer
Copy link
Contributor Author

@lorensr, I¡ve fixed this in my branch. Submitted a PR to @mquandalle but it has not been merged yet.

@tobsai
Copy link

tobsai commented Dec 24, 2014

Same issue, any ETA?

@lorensr lorensr added the bug label Jan 6, 2015
@lorensr
Copy link
Collaborator

lorensr commented Jan 7, 2015

@tobsai, we should be merging the change soon. @gbisheimer were you able to get polymer working with the components installed in .meteor/local/bower, or did you have to set it to a public/ directory as those in #31 had to?

@gbisheimer
Copy link
Contributor Author

@lorensr, I couldn't find a way to use polymer components under .meteor/local/bower folder because polymer components need to have access to each other's files, and you need to have them packaged in meteor during build (using compileStep.AddAsset). You can specify which assets are published by adding a main entry in bower.json (look at select2) and those will get published by meteor-bower automatically. But with polymer this is not possible as this entry was not included in any bower.json file of any component.
One possible option can be to use the aditionalFiles entry (deprecated when smart.json support was dropped) in main project bower.json referencing the files that should be included as meteor assets. The code is still alive in meteor-bower but not used anymore. Any other ideas?

lorensr added a commit that referenced this issue Jan 17, 2015
fixes #41 and adds support for .bowerrc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants