Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for correct https url parsing #135

Closed
vksysd opened this issue Jul 3, 2024 · 3 comments
Closed

Bug fix for correct https url parsing #135

vksysd opened this issue Jul 3, 2024 · 3 comments

Comments

@vksysd
Copy link

vksysd commented Jul 3, 2024

https://google.com is a valid url but doggo won't parse it to google.com before firing the DNS query.
The URL needs to be parsed properly.

@mr-karan
Copy link
Owner

mr-karan commented Jul 3, 2024

No it's not. DNS queries need a FQDN. That's different from a URL.

@mr-karan mr-karan closed this as completed Jul 3, 2024
@vksysd
Copy link
Author

vksysd commented Jul 3, 2024 via email

@mr-karan
Copy link
Owner

mr-karan commented Jul 3, 2024

No. DNS clients are not supposed to do that, per RFC 1034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants