-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate Globalping API for global network diagnostics #143
Conversation
Seems to make sense to me. @mr-karan please check |
Thanks for opening the PR. I'll review it over the weekend. |
Hey, when you have time please let us know of your feedback, we can make the appropriate changes :) |
Sorry, I'd been busy. I'll get back to this very soon. |
Hey, no worries if you're busy, just a small reminder. In case the PR has some obvious problems let us know so we could fix them. |
I am a little behind on keeping up with reviewing this, apologies for that. Overall LGTM. Just a minor change requested in the review. We're good to merge after this. |
How about we use --from and --probes instead of --gp-from and --gp-limit? |
Yep, I agree that |
Sure sounds good, feel free to merge then :) |
Thanks a lot for this, really appreciate it. ❤️ |
@jimaek does this output style work?
doggo google.com --from Germany
doggo google.com --from Germany --limit 2
doggo NS google.com --from Germany,Japan --limit 2