Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Globalping API for global network diagnostics #143

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

radulucut
Copy link
Contributor

@radulucut radulucut commented Jul 18, 2024

@jimaek does this output style work?

doggo google.com --from Germany

LOCATION                      	NAME       	TYPE	CLASS	TTL 	ADDRESS        	NAMESERVER 
Frankfurt, DE, EU, Macarne LLC	           	    	     	    	               	          	
(AS64289)                     	           	    	     	    	               	          	
                              	google.com.	A   	IN   	117s	142.250.184.206	private   

doggo google.com --from Germany --limit 2

LOCATION                      	NAME       	TYPE	CLASS	TTL 	ADDRESS        	NAMESERVER   
Frankfurt, DE, EU, Frantech   	           	    	     	    	               	            	
Solutions (AS53667)           	           	    	     	    	               	            	
                              	google.com.	A   	IN   	58s 	142.250.179.142	107.189.0.69	
Falkenstein, DE, EU, Hetzner  	           	    	     	    	               	            	
Online GmbH (AS24940)         	           	    	     	    	               	            	
                              	google.com.	A   	IN   	222s	142.250.185.238	private     

doggo NS google.com --from Germany,Japan --limit 2

LOCATION                      	NAME       	TYPE	CLASS	TTL    	ADDRESS        	NAMESERVER 
Frankfurt, DE, EU, Akenes SA  	           	    	     	       	               	          	
(AS61098)                     	           	    	     	       	               	          	
                              	google.com.	NS  	IN   	7000s  	ns3.google.com.	private   	
                              	google.com.	NS  	IN   	7000s  	ns1.google.com.	private   	
                              	google.com.	NS  	IN   	7000s  	ns2.google.com.	private   	
                              	google.com.	NS  	IN   	7000s  	ns4.google.com.	private   	
Tokyo, JP, AS, xTom Japan Co.,	           	    	     	       	               	          	
Ltd. (AS3258)                 	           	    	     	       	               	          	
                              	google.com.	NS  	IN   	327074s	ns2.google.com.	1.1.1.1   	
                              	google.com.	NS  	IN   	327074s	ns1.google.com.	1.1.1.1   	
                              	google.com.	NS  	IN   	327074s	ns3.google.com.	1.1.1.1   	
                              	google.com.	NS  	IN   	327074s	ns4.google.com.	1.1.1.1 

@jimaek
Copy link

jimaek commented Jul 18, 2024

Seems to make sense to me. @mr-karan please check

@radulucut radulucut marked this pull request as ready for review July 19, 2024 08:23
@mr-karan
Copy link
Owner

Thanks for opening the PR. I'll review it over the weekend.

@jimaek
Copy link

jimaek commented Jul 23, 2024

Hey, when you have time please let us know of your feedback, we can make the appropriate changes :)

@mr-karan
Copy link
Owner

Sorry, I'd been busy. I'll get back to this very soon.

@jimaek
Copy link

jimaek commented Sep 22, 2024

Hey, no worries if you're busy, just a small reminder. In case the PR has some obvious problems let us know so we could fix them.

@mr-karan
Copy link
Owner

mr-karan commented Sep 27, 2024

I am a little behind on keeping up with reviewing this, apologies for that. Overall LGTM. Just a minor change requested in the review. We're good to merge after this.

cmd/doggo/completions.go Outdated Show resolved Hide resolved
@jimaek
Copy link

jimaek commented Sep 27, 2024

How about we use --from and --probes instead of --gp-from and --gp-limit?
I think only --limit is an issue since --from is quite unique to Globalping.

@mr-karan
Copy link
Owner

How about we use --from and --probes instead of --gp-from and --gp-limit?
I think only --limit is an issue since --from is quite unique to Globalping.

Yep, I agree that --from is intuitive. However, just to keep this tool a bit more generic, in case we add a future service like Globalping, there could be a collision, hence I thought it's better to namespace it. Is that fine by you? I see @radulucut has already made the changes, so we can go ahead and merge.

@jimaek
Copy link

jimaek commented Sep 28, 2024

Sure sounds good, feel free to merge then :)

@mr-karan mr-karan merged commit 6666e97 into mr-karan:main Sep 30, 2024
@mr-karan
Copy link
Owner

Thanks a lot for this, really appreciate it. ❤️

@radulucut radulucut deleted the globalping branch September 30, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants