Soften the message when the stanza is not the correct one #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple stanza and they are tried one after the other, there should not be a log with level “warning”, but only a log with level “info”. Issue: mrash#337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple stanza and they are tried one after the other, there should not be a log with level “warning”, but only a log with level “info”.
The
log_msgin theelseis the previous one, it is the same message as the first one of theifbut with level DEBUG, and the second one in theifis new. It has the level INFO which is the same level as the log just before "(stanza # 1) SPA Packet from IP: x.x.x.x received with access source match", so that it is coherent to see what stanza is checked then its result.This will help monitoring the logs with less WARNINGs.
Issue: #337