Update docs, add GH action for docs, fix a few styleCheck hints #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular the `reduce_inline` call in `min` is weird. It seems the compiler confuses the argument and generic type and thus throws a hint.
nn_dsl was now the only file in the source root directory that actually contained actual source
Note: we should be generating this file from now on via GH actions. If that works, we can remove this file from the repo.
|
Let's merge this and see if the docs actually get built... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try to build the docs on GH actions...
Fixes the doc gen for the current behavior of
nim docas well as update it for PR #548.