Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mempool] Threading and/or Memory bug #53

Closed
mratsim opened this issue Dec 15, 2019 · 3 comments
Closed

[Mempool] Threading and/or Memory bug #53

mratsim opened this issue Dec 15, 2019 · 3 comments
Labels
concurrency 💥 memory 💫 seems to have disappeared 👻 Bugs that may or may not have been (unintentionally) fixed

Comments

@mratsim
Copy link
Owner

mratsim commented Dec 15, 2019

Seems like a tough one: https://dev.azure.com/numforge/Weave/_build/results?buildId=41&view=logs
mratsim added a commit that referenced this issue Dec 26, 2019
@mratsim
Fix #53 - race condition between thread-local memory pools availabili…
a91b779 
…ty and the moment a thread starts recycling memory
@mratsim mratsim mentioned this issue Dec 26, 2019
Merged
@mratsim
Copy link
Owner Author

mratsim commented Dec 26, 2019

And not solved :/ https://dev.azure.com/numforge/Weave/_build/results?buildId=173&view=logs&j=1d208bef-e69c-58c9-bad1-6607d24106c5&t=bc3bcfc8-cf91-5d93-3945-2815c3d1998d&l=169

@mratsim mratsim reopened this Dec 26, 2019
@mratsim
Copy link
Owner Author

mratsim commented Dec 29, 2019

Just so I don't lose it, LLVM sanitizer call under Windows:

nim c -r --cc:clang --passC:"-fsanitize=address" --passL:"-L/d/Apps/LLVM/lib/clang/9.0.0/lib/windows -fsanitize=address -lclang_rt.asan_dynamic-x86_64" --outdir:build weave/memory/memory_pools.nim

@mratsim mratsim mentioned this issue Dec 29, 2019
Merged
@mratsim
Copy link
Owner Author

mratsim commented Apr 25, 2020

Closing, the build logs were not saved on Azure and while there doesn't seem to have been any new occurrences recently.

@mratsim mratsim closed this as completed Apr 25, 2020
@mratsim mratsim added the seems to have disappeared 👻 Bugs that may or may not have been (unintentionally) fixed label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
concurrency 💥 memory 💫 seems to have disappeared 👻 Bugs that may or may not have been (unintentionally) fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mratsim