FQDN for temp and home drives #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @richfitz
I believe this does the trick, although it is a little hard to test. It updates the default home and temp folders to include ".dide.ic.ac.uk", and also updates the path_mapping function so that the non-domain addresses returned from wmic get .dide.ic.ac.uk appended onto the server, if they don't already have them.
But I am editing this without a very good grasp of how the whole thing works; what I am treating as "success" at the moment, is that in a fresh R session, with the new package, didehpc::didehpc_config() is returning me (snipped):
whereas before:
If this propogates through to the jobs, then I think this will workaround the horrible server issue we're currently working on.