Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-2281: overhaul package #82

Merged
merged 118 commits into from
Apr 19, 2021
Merged

mrc-2281: overhaul package #82

merged 118 commits into from
Apr 19, 2021

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Apr 7, 2021

This was my plan for Q1 2020 :-/

Depends on a bunch of stuff:

@richfitz richfitz marked this pull request as ready for review April 15, 2021 08:52
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, I'll fiddle through a couple of Windows tests that pass on GH, but fail locally for not obvious reasons so far. Nothing important. The vignettes: instructions seem clear to me, and following them worked exactly as described, so I think we are good to go!

@weshinsley weshinsley merged commit 071b8bd into master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment