Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint Biosecurity Initial Report #78

Merged
merged 28 commits into from
May 21, 2024
Merged

Conversation

cwhittaker1000
Copy link
Collaborator

Reviews from @athowes and @tbreweric welcome. I'm largely happy with the text here, so really I'm after:

  1. Things that don't make sense/appear to be wrong.
  2. Spelling mistakes.
  3. Incorrect figure references/things that haven't rendered properly that I'm missing etc.

Definitely don't spend too much time on this. 1 hour tops 😄

tbreweric and others added 26 commits May 9, 2024 10:52
…ions and figures for the first model demonstration for our partnerse
…le dataframe, convert counts to proportions, and convert data frame to long form for plotting
… some endemic simulations with varying immunity durations and simulation lengths
…exemplar data to the vignettes folder and the and figures and basic captions to the vignette
@athowes
Copy link
Collaborator

athowes commented May 20, 2024

Have run through will spell checker. Obvious mistake I can spot is that some of the text is cut-off in Figure 3.6:

image

(To solve this perhaps try patchwork -- in my experience better than cowplot. Better solution is to use facet_wrap but I know can be tricky. Easiest thing make the titles shorter.)

@cwhittaker1000 cwhittaker1000 merged commit c308a01 into main May 21, 2024
@cwhittaker1000 cwhittaker1000 deleted the tom-blueprint-simulations branch May 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants