Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL speculative docs #28

Merged
merged 6 commits into from
Aug 5, 2024
Merged

DSL speculative docs #28

merged 6 commits into from
Aug 5, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Apr 5, 2024

Merge after #44, as we use the domain bits from there

This is just a start, really

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c646382) to head (2907860).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3398      3398           
=========================================
  Hits          3398      3398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz mentioned this pull request Apr 8, 2024
@richfitz richfitz force-pushed the mrc-5185 branch 3 times, most recently from 03a0c59 to b206658 Compare July 19, 2024 07:57
@richfitz richfitz marked this pull request as ready for review July 31, 2024 15:51
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, couple of thoughts in the first para

vignettes/dsl.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Wes Hinsley <w.hinsley@imperial.ac.uk>
@richfitz richfitz merged commit bee199f into main Aug 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants