Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc rendering issues #74

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Fix doc rendering issues #74

merged 6 commits into from
Oct 2, 2024

Conversation

richfitz
Copy link
Member

  • missing title tags in the reference
  • we would benefit from section headers in the article list

@richfitz richfitz marked this pull request as ready for review September 26, 2024 15:35
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (3dacc35) to head (355200a).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          63       63           
  Lines        4331     4331           
=======================================
  Hits         4317     4317           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - couple of fixes

```

We can plot a greyscale visualisation of its density by computing the density over a grid. Normally this is not possible of course:

```{r}
a <- seq(-2, 6, length.out = 1000)
b <- seq(-2, 2, length.out = 1000)
z <- outer(a, b, function(a, b) dnorm(b) * dnorm((a - b^2) / 0.5))
z <- outer(a, b, function(alpha, beta) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above - it's not strictly "greyscale" - more sort of shades of roasted banana from yellow to gold. But it probably doesn't matter...

@@ -104,24 +74,40 @@ points(s[1, ], s[2, ], pch = 19, col = "#00000055")

It is not generally possible to directly sample from a density (otherwise MCMC and similar methods would not exist!). In these cases we need to use a sampler based on the density and if available possibly the gradient of the density.

We can start with a basic random-walk sampler
We can start with a basic random-walk sampler:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above on line 57, a typo - We can check than -> that

vignettes/samplers.Rmd Outdated Show resolved Hide resolved
richfitz and others added 2 commits October 1, 2024 22:27
Co-authored-by: Wes Hinsley <w.hinsley@imperial.ac.uk>
@richfitz richfitz merged commit 6ffdbb5 into main Oct 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants