-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc rendering issues #74
Conversation
richfitz
commented
Sep 26, 2024
- missing title tags in the reference
- we would benefit from section headers in the article list
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 63 63
Lines 4331 4331
=======================================
Hits 4317 4317
Misses 14 14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice - couple of fixes
``` | ||
|
||
We can plot a greyscale visualisation of its density by computing the density over a grid. Normally this is not possible of course: | ||
|
||
```{r} | ||
a <- seq(-2, 6, length.out = 1000) | ||
b <- seq(-2, 2, length.out = 1000) | ||
z <- outer(a, b, function(a, b) dnorm(b) * dnorm((a - b^2) / 0.5)) | ||
z <- outer(a, b, function(alpha, beta) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above - it's not strictly "greyscale" - more sort of shades of roasted banana from yellow to gold. But it probably doesn't matter...
@@ -104,24 +74,40 @@ points(s[1, ], s[2, ], pch = 19, col = "#00000055") | |||
|
|||
It is not generally possible to directly sample from a density (otherwise MCMC and similar methods would not exist!). In these cases we need to use a sampler based on the density and if available possibly the gradient of the density. | |||
|
|||
We can start with a basic random-walk sampler | |||
We can start with a basic random-walk sampler: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above on line 57, a typo - We can check than -> that
Co-authored-by: Wes Hinsley <w.hinsley@imperial.ac.uk>