Use workaround to avoid duckdb raising unnecessary warning #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Corresponding hintr PR at hivtools/hintr#498 |
r-ash
commented
Mar 20, 2024
| @@ -1,6 +1,7 @@ | |||
| ## Naomi <img src='images/naomi_hex.png' align="right" height="139" /> | |||
|
|
|||
|  | |||
| [](https://www.repostatus.org/#active) | |||
There was a problem hiding this comment.
Tidying this up whilst I'm here
r-ash
commented
Mar 20, 2024
| rvest \ | ||
| pkgbuild \ | ||
| testthat.buildkite |
There was a problem hiding this comment.
Tidying these old imports up too
rtesra
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After closing a db connection to duckdb when garbage collection runs we're seeing a warning raised about using
shutdown = TRUE. We are setting this flag, but the warning is still being raised. We can work around this see duckdb/duckdb-r#60