Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrc-5659 Runner Layout #106

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Mrc-5659 Runner Layout #106

merged 5 commits into from
Aug 29, 2024

Conversation

absternator
Copy link
Contributor

The following PR creates the layout for the runner pages. This includes the logs and run page, and users only have access to this if they have packet.run permission... below is screenshot of how it looks

Testing:

  1. With admin user ensure can see link showing Runner page. When navigating ensure see layout as shown by screen shot. also try navigating b/w sidebar (logs and run) to see different page and URLs change.
  2. Create user without packet.run permission and login. You should no be able to see Runner link... Also try head to URL /runner or /runner/logs and you should get unauthorized page
    image

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (0bf5fba) to head (773a801).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   96.10%   97.16%   +1.05%     
==========================================
  Files         106      109       +3     
  Lines         976      987      +11     
  Branches      253      258       +5     
==========================================
+ Hits          938      959      +21     
+ Misses         37       27      -10     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The `mockGetUserFromLocalStorage` function in the `Header.test.tsx` file was updated to return the result of the `mockUserState` function. This change ensures that the left navigation is rendered correctly when a user is present.
@absternator absternator merged commit dfc0b52 into main Aug 29, 2024
5 checks passed
@absternator absternator deleted the mrc-5659-runner-layout branch August 29, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants