-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mrc-5365 - Enable auth for packet read lists #89
Mrc-5365 - Enable auth for packet read lists #89
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mrc-5373-update-permissions #89 +/- ##
===============================================================
+ Coverage 95.95% 95.97% +0.01%
===============================================================
Files 105 106 +1
Lines 964 968 +4
Branches 248 248
===============================================================
+ Hits 925 929 +4
Misses 38 38
Partials 1 1 ☔ View full report in Codecov by Sentry. |
…ide/packit into mrc-5365-auth-lists-enable
…ameContaining method
…sionScopePaths instead of getScopePaths
…ide/packit into mrc-5365-auth-lists-enable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just noting a discussion had in person, used can call their packet groups whatever they want and this can mess up the urls (e.g. if they include a ;
in their packet group names) so we should use unicode like google does for search results to avoid this problem
This ticket is focused on enabling auth for packet lists + some other updates. Below is the work done
AuthorizationLogic.kt
and the filtering annotation is inPacketRepository.kt
andPacketGroupRepository.kt
Testing Urls:
Test cases :