Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outpack metadata #96

Closed
wants to merge 8 commits into from
Closed

Conversation

M-Kusumgar
Copy link
Contributor

@M-Kusumgar M-Kusumgar commented Jul 29, 2024

This just updates the metadata data classes to more closely resemble the outpack json schema. You can go on the link to the schema and compare with the kotlin data classes. I am actually not sure where this is tested. I don't think this actually is as far as I can tell which is fair enough as this is just the data class definitions

This update was required because you would get the error below if you tried to look at the summary of the packet that was run with a detached head (so not on any branch and so the git.branch would be null in the metadata) and the frontend would receive this error:

{
    "error": {
        "detail": "Error while extracting response for type [packit.model.OutpackResponse<packit.model.PacketMetadata>] and content type [application/json]",
        "error": "OTHER_ERROR"
    },
    "data": {},
    "status": "failure"
}

i don't think i can test the case when we have git.branch as null because that requires me to do a detached checkout in packit which sounds messy, we will know pretty quickly if this works to solve the error if we deploy to packit.dide.ic.ac.uk and the error goes away

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (ced309d) to head (8c58616).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         106      106           
  Lines         975      975           
  Branches      252      252           
=======================================
  Hits          936      936           
  Misses         38       38           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Kusumgar M-Kusumgar closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant