Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the metadata data classes to more closely resemble the outpack json schema. You can go on the link to the schema and compare with the kotlin data classes. I am actually not sure where this is tested. I don't think this actually is as far as I can tell which is fair enough as this is just the data class definitions
This update was required because you would get the error below if you tried to look at the summary of the packet that was run with a detached head (so not on any branch and so the git.branch would be
null
in the metadata) and the frontend would receive this error:i don't think i can test the case when we have git.branch as
null
because that requires me to do a detached checkout in packit which sounds messy, we will know pretty quickly if this works to solve the error if we deploy to packit.dide.ic.ac.uk and the error goes away