Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile Safari's ReferenceError #65

Closed
wants to merge 1 commit into from

Conversation

sairoutine
Copy link

I encountered the same bug as #47.
The reason is that a new code does not use self.performance instead of performance.
I fixed it.

Thanks.

@mrdoob
Copy link
Owner

mrdoob commented Oct 29, 2016

Is this still and issue on iOS10?

@sairoutine
Copy link
Author

I don't have iOS10, but in my iOS 8.1, this is still occured.

@mrdoob
Copy link
Owner

mrdoob commented Oct 29, 2016

I see I see. Would it be possible to not include the build in this PR. Seems to be causing conflicts.

@sairoutine
Copy link
Author

I deleted the built file. Could you please merge this?

@pavle-goloskokovic
Copy link

+1 for merging this, got the same error on older version of Opera

@sairoutine
Copy link
Author

@mrboob How about this PR?

@mrdoob
Copy link
Owner

mrdoob commented Apr 6, 2020

Sorry for the delay... Is this still needed?

@sairoutine
Copy link
Author

@mrdoob
I still maintain the app for iOS 8.1 as necessary.
It would be appreciated if you could merge this.

@sairoutine
Copy link
Author

if you were not willing to add this code to your repository, I would take down this PR and fork this repo.

@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2020

How many people use iOS 8.1?

@sairoutine
Copy link
Author

Now in 2020, almost all iOS 8 share is 0.0%
https://www.statista.com/statistics/565270/apple-devices-ios-version-share-worldwide/

@mrdoob mrdoob closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants