Object3D: Renamed removeAll to clear.

mrdoob · Oct 14, 2020 · 315d0fc · linbingquan · Oct 18, 2020 · Mugen87
1 parent 2b082dc
commit 315d0fc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/docs/api/en/core/Object3D.html b/docs/api/en/core/Object3D.html
@@ -314,7 +314,7 @@ <h3>[method:this remove]( [param:Object3D object], ... )</h3>
 		Removes *object* as child of this object. An arbitrary number of objects may be removed.
 		</p>
 
-		<h3>[method:this removeAll]()</h3>
+		<h3>[method:this clear]()</h3>
 		<p>
 		Removes all child objects.
 		</p>

diff --git a/src/core/Object3D.d.ts b/src/core/Object3D.d.ts
@@ -319,7 +319,7 @@ export class Object3D extends EventDispatcher {
 	/**
 	 * Removes all child objects.
 	 */
-	removeAll(): this;
+	clear(): this;
 
 	/**
 	 * Adds object as a child of this, while maintaining the object's world transform.

diff --git a/src/core/Object3D.js b/src/core/Object3D.js
@@ -370,7 +370,7 @@ Object3D.prototype = Object.assign( Object.create( EventDispatcher.prototype ),
 
 	},
 
-	removeAll: function () {
+	clear: function () {
 
 		for ( let i = 0; i < this.children.length; i ++ ) {
 

diff --git a/test/unit/src/core/Object3D.tests.js b/test/unit/src/core/Object3D.tests.js
@@ -296,7 +296,7 @@ export default QUnit.module( 'Core', () => {
 
 		} );
 
-		QUnit.test( "add/remove/removeAll", ( assert ) => {
+		QUnit.test( "add/remove/clear", ( assert ) => {
 
 			var a = new Object3D();
 			var child1 = new Object3D();
@@ -330,7 +330,7 @@ export default QUnit.module( 'Core', () => {
 
 			a.add( child1 );
 			assert.strictEqual( a.children.length, 2, "The first child was added to the parent" );
-			a.removeAll();
+			a.clear();
 			assert.strictEqual( a.children.length, 0, "All childrens were removed" );
 			assert.strictEqual( child1.parent, null, "First child has no parent" );
 			assert.strictEqual( child2.parent, null, "Second child has no parent" );