Skip to content

Commit

Permalink
WebGPURenderer: Clean up.
Browse files Browse the repository at this point in the history
  • Loading branch information
Mugen87 committed Sep 6, 2020
1 parent b0f4546 commit 56d0b32
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions examples/jsm/renderers/webgpu/WebGPUBindings.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ class WebGPUBindings {
array.set( object.matrixWorld.elements, 0 );
array.set( object.modelViewMatrix.elements, 16 );

return true; // TODO: implement caching (return false when cache hits occurs)
return true; // @TODO: implement caching (return false when cache hits occurs)

} );

Expand Down Expand Up @@ -316,7 +316,7 @@ class WebGPUBindings {
array.set( object.matrixWorld.elements, 0 );
array.set( object.modelViewMatrix.elements, 16 );

return true; // TODO: implement caching (return false when cache hits occurs)
return true; // @TODO: implement caching (return false when cache hits occurs)

} );

Expand Down Expand Up @@ -346,7 +346,7 @@ class WebGPUBindings {
array.set( object.matrixWorld.elements, 0 );
array.set( object.modelViewMatrix.elements, 16 );

return true; // TODO: implement caching (return false when cache hits occurs)
return true; // @TODO: implement caching (return false when cache hits occurs)

} );

Expand All @@ -372,7 +372,7 @@ class WebGPUBindings {
array.set( camera.projectionMatrix.elements, 0 );
array.set( camera.matrixWorldInverse.elements, 16 );

return true; // TODO: implement caching (return false when cache hits occurs)
return true; // @TODO: implement caching (return false when cache hits occurs)

} );

Expand Down
8 changes: 4 additions & 4 deletions examples/jsm/renderers/webgpu/WebGPUTextures.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class WebGPUTextures {

if ( textureProperties.textureGPU !== undefined ) {

// TODO: Avoid calling of destroy() in certain scenarios. When only the contents of a texture
// @TODO: Avoid calling of destroy() in certain scenarios. When only the contents of a texture
// are updated, a buffer upload should be sufficient. However, if the user changes
// the dimensions of the texture, format or usage, a new instance of GPUTexture is required.

Expand Down Expand Up @@ -178,7 +178,7 @@ class WebGPUTextures {
height: height,
depth: 1
},
format: GPUTextureFormat.BRGA8Unorm, // TODO: Make configurable
format: GPUTextureFormat.BRGA8Unorm, // @TODO: Make configurable
usage: GPUTextureUsage.OUTPUT_ATTACHMENT | GPUTextureUsage.SAMPLED
} );

Expand All @@ -201,7 +201,7 @@ class WebGPUTextures {
height: height,
depth: 1
},
format: GPUTextureFormat.Depth24PlusStencil8, // TODO: Make configurable
format: GPUTextureFormat.Depth24PlusStencil8, // @TODO: Make configurable
usage: GPUTextureUsage.OUTPUT_ATTACHMENT
} );

Expand Down Expand Up @@ -342,7 +342,7 @@ class WebGPUTextures {
_copyBufferToTexture( image, format, textureGPU ) {

// this code assumes data textures in RGBA format
// TODO: Consider to support valid buffer layouts with other formats like RGB
// @TODO: Consider to support valid buffer layouts with other formats like RGB

const device = this.device;
const data = image.data;
Expand Down

0 comments on commit 56d0b32

Please sign in to comment.