Fixed pixellated backgrounds when using hdr cubemaps.

mrdoob · Jan 30, 2019 · abb0e11 · abb0e11
1 parent 8ced1eb
commit abb0e11
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 24 deletions.
diff --git a/examples/webgl_materials_envmaps_hdr.html b/examples/webgl_materials_envmaps_hdr.html
@@ -117,6 +117,9 @@
 
 						hdrCubeRenderTarget = pmremCubeUVPacker.CubeUVRenderTarget;
 
+						hdrCubeMap.magFilter = THREE.LinearFilter;
+						hdrCubeMap.needsUpdate = true;
+
 						pmremGenerator.dispose();
 						pmremCubeUVPacker.dispose();
 

diff --git a/examples/webgl_materials_standard.html b/examples/webgl_materials_standard.html
@@ -102,16 +102,6 @@
 
 				//
 
-				new THREE.CubeTextureLoader()
-					.setPath( 'textures/cube/pisa/' )
-					.load( [ 'px.png', 'nx.png', 'py.png', 'ny.png', 'pz.png', 'nz.png' ], function ( textureCube ) {
-
-						scene.background = textureCube;
-
-					} );
-
-				//
-
 				var material = new THREE.MeshStandardMaterial();
 
 				new THREE.OBJLoader()
@@ -174,7 +164,10 @@
 					material.envMap = hdrCubeRenderTarget.texture;
 					material.needsUpdate = true; // is this needed?
 
-					hdrCubeMap.dispose();
+					hdrCubeMap.magFilter = THREE.LinearFilter;
+					hdrCubeMap.needsUpdate = true;
+					scene.background = hdrCubeMap;
+
 					pmremGenerator.dispose();
 					pmremCubeUVPacker.dispose();
 

diff --git a/examples/webgl_materials_variations_physical.html b/examples/webgl_materials_variations_physical.html
@@ -82,13 +82,7 @@
 
 				};
 
-
-				var textureCube = new THREE.CubeTextureLoader()
-					.setPath( 'textures/cube/pisa/' )
-					.load( [ 'px.png', 'nx.png', 'py.png', 'ny.png', 'pz.png', 'nz.png' ] );
-
 				scene = new THREE.Scene();
-				scene.background = textureCube;
 
 				var hdrUrls = genCubeUrls( './textures/cube/pisaHDR/', '.hdr' );
 				var hdrCubeRenderTarget = null;
@@ -150,7 +144,10 @@
 
 					}
 
-					hdrCubeMap.dispose();
+					hdrCubeMap.magFilter = THREE.LinearFilter;
+					hdrCubeMap.needsUpdate = true;
+					scene.background = hdrCubeMap;
+
 					pmremGenerator.dispose();
 					pmremCubeUVPacker.dispose();
 

diff --git a/examples/webgl_materials_variations_standard.html b/examples/webgl_materials_variations_standard.html
@@ -80,12 +80,7 @@
 
 				};
 
-				var textureCube = new THREE.CubeTextureLoader()
-					.setPath( 'textures/cube/pisa/' )
-					.load( [ 'px.png', 'nx.png', 'py.png', 'ny.png', 'pz.png', 'nz.png' ] );
-
 				scene = new THREE.Scene();
-				scene.background = textureCube;
 
 				var hdrUrls = genCubeUrls( './textures/cube/pisaHDR/', '.hdr' );
 				var hdrCubeRenderTarget = null;
@@ -154,7 +149,10 @@
 
 					}
 
-					hdrCubeMap.dispose();
+					hdrCubeMap.magFilter = THREE.LinearFilter;
+					hdrCubeMap.needsUpdate = true;
+					scene.background = hdrCubeMap;
+
 					pmremGenerator.dispose();
 					pmremCubeUVPacker.dispose();