InstancedBufferGeometry: Fix .copy() and .clone()

mrdoob · Aug 18, 2017 · af19783 · af19783
1 parent 177bf99
commit af19783
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 35 deletions.
diff --git a/examples/webgl_buffergeometry_instancing_billboards.html b/examples/webgl_buffergeometry_instancing_billboards.html
@@ -139,7 +139,10 @@
 			scene = new THREE.Scene();
 
 			geometry = new THREE.InstancedBufferGeometry();
-			geometry.copy( new THREE.CircleBufferGeometry( 1, 6 ) );
+			var circleGeometry = new THREE.CircleBufferGeometry( 1, 6 );
+
+			geometry.index = circleGeometry.index;
+			geometry.attributes = circleGeometry.attributes;
 
 			var particleCount = 75000;
 

diff --git a/src/core/InstancedBufferGeometry.js b/src/core/InstancedBufferGeometry.js
@@ -19,47 +19,19 @@ InstancedBufferGeometry.prototype = Object.assign( Object.create( BufferGeometry
 
 	isInstancedBufferGeometry: true,
 
-	addGroup: function ( start, count, materialIndex ) {
-
-		this.groups.push( {
-
-			start: start,
-			count: count,
-			materialIndex: materialIndex
-
-		} );
-
-	},
-
 	copy: function ( source ) {
 
-		var index = source.index;
-
-		if ( index !== null ) {
-
-			this.setIndex( index.clone() );
+		BufferGeometry.prototype.copy.call( this, source );
 
-		}
+		this.maxInstancedCount = source.maxInstancedCount;
 
-		var attributes = source.attributes;
-
-		for ( var name in attributes ) {
-
-			var attribute = attributes[ name ];
-			this.addAttribute( name, attribute.clone() );
-
-		}
-
-		var groups = source.groups;
-
-		for ( var i = 0, l = groups.length; i < l; i ++ ) {
+		return this;
 
-			var group = groups[ i ];
-			this.addGroup( group.start, group.count, group.materialIndex );
+	},
 
-		}
+	clone: function () {
 
-		return this;
+		return new this.constructor().copy( this );
 
 	}