Skip to content

Commit

Permalink
Merge pull request #11225 from WestLangley/dev-helper_color
Browse files Browse the repository at this point in the history
Set LightHelper color equal to the light color
  • Loading branch information
WestLangley committed Apr 24, 2017
2 parents bdc4302 + 0cc76e6 commit e49c8ad
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/helpers/DirectionalLightHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ DirectionalLightHelper.prototype.update = function () {
var targetLine = this.children[ 1 ];

lightPlane.lookAt( v3 );
lightPlane.material.color.copy( this.light.color ).multiplyScalar( this.light.intensity );
lightPlane.material.color.copy( this.light.color );

targetLine.lookAt( v3 );
targetLine.scale.z = v3.length();
Expand Down
4 changes: 2 additions & 2 deletions src/helpers/HemisphereLightHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ HemisphereLightHelper.prototype.update = function () {

var colors = mesh.geometry.getAttribute( 'color' );

color1.copy( this.light.color ).multiplyScalar( this.light.intensity );
color2.copy( this.light.groundColor ).multiplyScalar( this.light.intensity );
color1.copy( this.light.color );
color2.copy( this.light.groundColor );

for ( var i = 0, l = colors.count; i < l; i ++ ) {

Expand Down
4 changes: 2 additions & 2 deletions src/helpers/PointLightHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function PointLightHelper( light, sphereSize ) {

var geometry = new SphereBufferGeometry( sphereSize, 4, 2 );
var material = new MeshBasicMaterial( { wireframe: true, fog: false } );
material.color.copy( this.light.color ).multiplyScalar( this.light.intensity );
material.color.copy( this.light.color );

Mesh.call( this, geometry, material );

Expand Down Expand Up @@ -57,7 +57,7 @@ PointLightHelper.prototype.dispose = function () {

PointLightHelper.prototype.update = function () {

this.material.color.copy( this.light.color ).multiplyScalar( this.light.intensity );
this.material.color.copy( this.light.color );

/*
var d = this.light.distance;
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/SpotLightHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ SpotLightHelper.prototype.update = function () {

this.cone.lookAt( vector2.sub( vector ) );

this.cone.material.color.copy( this.light.color ).multiplyScalar( this.light.intensity );
this.cone.material.color.copy( this.light.color );

};

Expand Down

0 comments on commit e49c8ad

Please sign in to comment.