Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scene.background affected by tonemapping #13066

Closed
pikilipita opened this issue Jan 8, 2018 · 7 comments
Closed

scene.background affected by tonemapping #13066

pikilipita opened this issue Jan 8, 2018 · 7 comments

Comments

@pikilipita
Copy link

images displayed on the background of the canvas using scene.background are affected by environment maps, in my case, they get darken.

I thought the purpose of the scene background was to display an image on the back of the canvas, but without the need of using an html tag.

In cases like the one below, I would expect the scene background not to be affected in any way by the scene lightning.

screen shot 2018-01-08 at 14 59 59

@WestLangley
Copy link
Collaborator

Can you please provide a live example to demonstrate your issue?

@pikilipita
Copy link
Author

While doing the example, I found out that is it not directly the envmap that is affecting the scene background, but the:
renderer.toneMapping
and
renderer.toneMappingExposure
values

here's the example:
http://lune.live/scene_background/

@WestLangley
Copy link
Collaborator

OK, that makes more sense.

Is it acceptable to set a CSS background and set `WebGLRenderer( { alpha: true } ), instead?

@pikilipita
Copy link
Author

I'm using scene.background to I can make screengrabs of the canvas that include the background.
That's how are generated all the thumbnails on this page:
https://xr.plus

if the image is outside of the canvas is will be excluded from the screengrab.

@WestLangley
Copy link
Collaborator

Got it.

Do you require tonemapping in your app?

renderer.toneMapping = THREE.NoToneMapping;

@pikilipita
Copy link
Author

Ideally,
I would like to let users adjust the exposure of their environment map, like here:
https://threejs.org/examples/webgl_materials_envmaps_hdr.html

@mrdoob mrdoob modified the milestones: r90, r91 Jan 17, 2018
@mrdoob mrdoob modified the milestones: r91, r92 Mar 14, 2018
@mrdoob mrdoob modified the milestones: r92, r93 Apr 18, 2018
@mrdoob mrdoob modified the milestones: r93, r94 May 22, 2018
@mrdoob mrdoob modified the milestones: r94, r95 Jun 27, 2018
@mrdoob mrdoob modified the milestones: r95, r96 Jul 31, 2018
@mrdoob mrdoob modified the milestones: r96, r97 Aug 30, 2018
@WestLangley WestLangley changed the title scene.background colors are affected by environment maps scene.background affected by tonemapping Sep 4, 2018
@mrdoob
Copy link
Owner

mrdoob commented Sep 26, 2018

As discussed in #14827, backgrounds should be affected by tonemapping. #14856 aligned the behaviour to not be affected but we'll eventually implement the shaders bits so they're affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants