Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tonemapping of scene background texture #14841

Closed
wants to merge 1 commit into from

Conversation

WestLangley
Copy link
Collaborator

Fixes #13066.

As discussed in #14827.

@WestLangley
Copy link
Collaborator Author

An alternate solution is to use a custom ShaderMaterial for the background plane mesh instead of MeshBasicMaterial, but I think this approach is OK.

@aardgoose
Copy link
Contributor

FWIW I've put together a ShaderMaterial version which has the background rendered after the opaque objects in the scene.

dev...aardgoose:background-texture

@mrdoob mrdoob added this to the r97 milestone Sep 4, 2018
@mrdoob
Copy link
Owner

mrdoob commented Sep 4, 2018

FWIW I've put together a ShaderMaterial version which has the background rendered after the opaque objects in the scene.

That looks good! Would you like to do a PR with it?

@WestLangley
Copy link
Collaborator Author

The shader approach by @aardgoose is OK with me, as long as the rendering order is correct.

@WestLangley
Copy link
Collaborator Author

Closing in favor of #14856.

@WestLangley WestLangley closed this Sep 5, 2018
@WestLangley WestLangley deleted the dev-tonemapping branch September 19, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants