Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgesGeometry.toJSON not working correctly #16087

Closed
3 of 11 tasks
Ozymandias1 opened this issue Mar 28, 2019 · 2 comments
Closed
3 of 11 tasks

EdgesGeometry.toJSON not working correctly #16087

Ozymandias1 opened this issue Mar 28, 2019 · 2 comments

Comments

@Ozymandias1
Copy link

i try to make a edgesgeometry object and save by json.

but, it can't EdgesGeometry.toJSON() function are work but something weird,

it is show by type's are EdgesGeometry, but generator are BufferGeometry.toJSON, and any vertex or index data not converted json(it's empty).

threerr

can i fix it?

Three.js version
  • Dev
  • r102
  • ...
Browser
  • [] All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • [] All of them
  • Windows
  • macOS
  • Linux
  • Android
  • iOS
Hardware Requirements (graphics card, VR Device, ...)

i7-4790, 16gbRam, Geforce GTX 1060 3gb

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 28, 2019

Yes, this is a current limitation of the library. There was already a PR (#14357) to solve the issue but it was not accepted. The problematic part is restoring the helpers during the deserialization process since they depend on other objects. I guess my proposed solution at that time was not convincing since the necessary logic in ObjectLoader needs an additional step and introduces some redundancies 😇

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 4, 2020

Closing in favor of #16340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants