Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The combination of DirectionalLight and Environment Maps results in material artifacts in the Pixel 3 #19479

Closed
3 of 13 tasks
jgsacris opened this issue May 27, 2020 · 8 comments
Closed
3 of 13 tasks

Comments

@jgsacris
Copy link

Description of the problem

When combining DirectionalLight and Environment Maps with GLTF models results in very noticeable surface artifacts on the 3D model when viewed on the Pixel 3

Start model with environment map and directional light:
envMap-direct-light (2)

Start model with only directional light:
direct-light-no-envMap (2)

Star model with only environment map:
envMap-no-direct-light (2)

Different model with directional light and environment map:
envMap-direct-light2 (2)

Three.js version
  • Dev
  • r116
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • macOS
  • Linux
  • Android
  • iOS
Hardware Requirements (graphics card, VR Device, ...)

Problem only seen on Google Pixel 3
The device is running Android version 10

@mrdoob
Copy link
Owner

mrdoob commented May 27, 2020

Could you create a jsfiddle that reproduces the issue on the device?

@mrdoob mrdoob added this to the r118 milestone May 27, 2020
@jgsacris
Copy link
Author

Here is a jsFiddle where this problem can be reviewed:

https://jsfiddle.net/jg4inr/vy7qsnok/41/

@Mugen87
Copy link
Collaborator

Mugen87 commented May 28, 2020

I've tested the fiddle on a Pixel 1 (with Android 10) and it looks like on my Desktop. So no rendering artifacts.

@jgsacris
Copy link
Author

We tested on two different Pixel 3's that we have in the office for development and both have this issue so it is not particular to one device. We are getting hold of a Pixel 4 and we will report the findings here.

@mrdoob
Copy link
Owner

mrdoob commented May 28, 2020

Yes, this is a Pixel 3 issue. I've bumped on this before. Thanks for the jsfiddle! 🙏

@elalish
Copy link
Contributor

elalish commented May 28, 2020

Indeed, this is a problem I'm hitting all the time now in model-viewer, since I only have a Pixel 3 to test on. I think it's very closely related to a bug I fixed a few months ago by refactoring a shadow shader: #18315. It was pretty clear the shader wasn't wrong, but any small change would make this driver bug appear or disappear.

@mrdoob mrdoob modified the milestones: r118, r119 Jun 24, 2020
@mrdoob mrdoob modified the milestones: r119, r120 Jul 29, 2020
@mrdoob mrdoob modified the milestones: r120, r121 Aug 25, 2020
@mrdoob mrdoob modified the milestones: r121, r122 Sep 29, 2020
@mrdoob mrdoob modified the milestones: r122, r123 Oct 28, 2020
@mrdoob mrdoob modified the milestones: r123, r124 Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 16, 2021

Does this issue still appear with Android 11?

BTW: The above fiddle looks good on a Pixel 4a and Android 11.

@mrdoob
Copy link
Owner

mrdoob commented Feb 16, 2021

Seems like we can!

This screenshot is from a Pixel 3 running Android 11:

Screenshot_20210216-122502

@mrdoob mrdoob closed this as completed Feb 16, 2021
@mrdoob mrdoob removed this from the r126 milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants