Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featured request : Parallax/heightmap Shader #22529

Closed
kylebakerio opened this issue Sep 11, 2021 · 8 comments
Closed

featured request : Parallax/heightmap Shader #22529

kylebakerio opened this issue Sep 11, 2021 · 8 comments

Comments

@kylebakerio
Copy link

kylebakerio commented Sep 11, 2021

Is your feature request related to a problem? Please describe.

Would like to be able to implement a parallax texture /heightmap without geometry easily. This would enable richer ground elements, creating the illusion of depth without the weight of adding the appropriate geometry in many cases--likewise with building textures. (If I'm not mistaken--if I am, let me know!)

Describe the solution you'd like

It should be equivalent to the functionality present out-of-the-box in Babylon described here: https://doc.babylonjs.com/divingDeeper/materials/using/parallaxMapping
and the end result should (I think) be what is achieved here in this THREE demo: https://mebiusbox.github.io/contents/pixyjs/samples/shader_parallax_occlusion.html

Personally, I'll immediately be trying to figure out how to include it in A-Frame, as that's the context in which I use THREE. I just want it to be as easy to add as any other map/texture stuff.

Describe alternatives you've considered

I've tried finding a THREE dev to pay to build this. I've asked for instructions on how to build this, though I'm out of my depth here. Clearly it is possible using THREE, just not made easy. I can find old issues discussing this, but it seems to have never been prioritized.

Additional context

Here are the assets I have that I'd like to turn into a parallax shader effect--if other assets are needed, I have an artist that can produce them, let me know how this should be designed and come up with an 'input' spec to produce the desired output.

I'm happy to put a bounty on this--tell me your hours and rate, and if it's reasonable, I can get it covered in our dev budget. If you can produce it within the next week or so, I will provide a bonus on top of pay. I'd love to see this be a reusable open source component. Also willing to pay to have this implemented as an A-Frame component.

image

@RenaudRohlinger
Copy link
Collaborator

😬 #22370

@mrdoob
Copy link
Owner

mrdoob commented Sep 11, 2021

Yeah, if you don't need lighting you can find the code here:
https://raw.githack.com/mrdoob/three.js/r131/examples/webgl_materials_parallaxmap.html

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 12, 2021

Also consider to use the Jobs category in the forum for such requests.

@mrdoob mrdoob closed this as completed Sep 12, 2021
@kylebakerio
Copy link
Author

I did post in jobs first, and also posted in Reddit as well as the discord. I got two leads in jobs, but neither followed up.

I didn't have capacity in this job to go deep enough into THREE to figure out how to follow that example myself within an A-Frame context, unfortunately. Sadly, this project is wrapping up now. Grass was a nice-to-have, guess we'll go without and I'll look into implementing it myself next time.

@mrdoob
Copy link
Owner

mrdoob commented Sep 15, 2021

When did you start working in the project?

@kylebakerio
Copy link
Author

Yeah... this client does really rapid dev, to put it in kind terms, haha. I'm building two for them simultaneously, while managing a third. we even had to pass on a fourth. somehow, all have their deadlines this week.

We weren't able to find another dev in time, which is why two fell on me to do, and we only had a little over a month to negotiate, plan, and implement all of them, so... it's been quite a sprint. ¯_(ツ)_/¯

pretty stressful, but can't complain about the pay.

@mrdoob
Copy link
Owner

mrdoob commented Sep 15, 2021

Please, do not unload that stress into open source libraries. Imagine if everyone did that.

@kylebakerio
Copy link
Author

kylebakerio commented Sep 15, 2021

I just saw what looked like a missing feature in a library I enjoy and gain from utilizing, and a chance to pay someone to contribute. I'm not sure what you mean by unloading stress... It was an urgent window of opportunity, but I'm not unloading anything on anyone.

I love chances to do things like this.

And if everyone were willing to drop $1k to pay for features they want in open source libraries when they needed it, I think open source would probably be in a pretty cool place.

@kylebakerio kylebakerio changed the title BOUNTY: WILL PAY YOU TO DO OPEN SOURCE | Parallax/heightmap Shader featured request : Parallax/heightmap Shader Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants