Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve this line #2323

Closed
ajax333221 opened this issue Aug 15, 2012 · 1 comment
Closed

Improve this line #2323

ajax333221 opened this issue Aug 15, 2012 · 1 comment
Labels
Suggestion

Comments

@ajax333221
Copy link 

frameHeight = frameHeight !== undefined ? frameHeight : 24;

can be rewritten safely to:

if(frameHeight===undefined)frameHeight=24;

Benefits:
-more readable
-performs better (I believe) since its value will only change when needed

Sorry that I don't know the exact line number, I just read this line from this question
mrdoob added a commit that referenced this issue Aug 15, 2012
@mrdoob
Improved camera.setLens code as suggested in #2323.
24a6a53
@mrdoob
Copy link
Owner

mrdoob commented Aug 15, 2012

Thanks!

@mrdoob mrdoob closed this as completed Aug 15, 2012
wvl pushed a commit to wvl/three.js that referenced this issue Nov 28, 2012
@mrdoob
(threejs src) Improved camera.setLens code as suggested in mrdoob#2323.
ec9c51d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrdoob @ajax333221