Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax Errors on Line 388 and line 2066 #8958

Closed
3 of 12 tasks
qbytx opened this issue May 21, 2016 · 6 comments
Closed
3 of 12 tasks

Syntax Errors on Line 388 and line 2066 #8958

qbytx opened this issue May 21, 2016 · 6 comments

Comments

@qbytx
Copy link
Contributor

qbytx commented May 21, 2016 •
edited
Loading

Edit: (I am referring to convert_to_threejs.py)

Description of the problem

String syntax errors on line 388 and line 2066.

Line 388:
print "Unknown type of Material", getMaterialName(material)
Should be:
print ("Unknown type of Material"), getMaterialName(material)

Line 2066:
print "I/O error({0}): {1} {2}".format(e.errno, e.strerror, url)
Should be:
print ("I/O error({0}): {1} {2}").format(e.errno, e.strerror, url)

Three.js version
  • Dev
  • r77
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
Hardware Requirements (graphics card, VR Device, ...)
@mrdoob
Copy link
Owner

mrdoob commented May 21, 2016

What file are you talking about?

@Mugen87
Copy link
Collaborator

Mugen87 commented May 21, 2016

I think the issue refers to these two lines in utils/converters/fbx/convert_to_threejs.py

Line 388
Line 2066

@qbytx
Copy link
Contributor Author

qbytx commented May 22, 2016

Yes, sorry, forgot to specifically mention that I was talking about convert_to_threejs.py, my bad!

@mrdoob
Copy link
Owner

mrdoob commented May 24, 2016

@Pandakub would you like to do a Pull Request with the fix?

@qbytx
Copy link
Contributor Author

qbytx commented Jun 20, 2016

done! :)

@mrdoob
Copy link
Owner

mrdoob commented Jun 20, 2016

@Pandakub Thanks!

@mrdoob mrdoob closed this as completed Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrdoob @Mugen87 @qbytx