GLTFLoader: Top-down loading for cameras. #12119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reviewing. |
donmccurdy
force-pushed
the
feat-gltf-td-cameras
branch
from
43ad28b
to
253e509
Compare
|
No worries, thanks! it is rebased now. |
takahirox
reviewed
Oct 17, 2017
examples/js/loaders/GLTFLoader.js
Outdated
|
|
||
| var _camera; | ||
| if ( !params ) { |
There was a problem hiding this comment.
Very minor thing tho, you need an space after ! as the coding style.
if ( ! params ) {
takahirox
reviewed
Oct 17, 2017
examples/js/loaders/GLTFLoader.js
Outdated
| dependencies.cameras = dependencies.cameras || []; | ||
| var scenes = dependencies.scenes; | ||
| var scene = scenes[ json.scene || 0 ]; | ||
| var animations = dependencies.animations; |
There was a problem hiding this comment.
Is this intended change that animations will be undefined if glTF doesn't have animations tho it was []?
|
Looks good other than two minor things as I commented. |
takahirox
approved these changes
Oct 17, 2017
donmccurdy
force-pushed
the
feat-gltf-td-cameras
branch
from
253e509
to
f122850
Compare
|
Done, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 for #11924.
/cc @takahirox