Loaders: Improve code quality #12168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! |
takahirox
reviewed
Sep 20, 2017
| @@ -4061,7 +4065,6 @@ | |||
| // The first three data sizes depends on version. | |||
| var endOffset = ( version >= 7500 ) ? reader.getUint64() : reader.getUint32(); | |||
| var numProperties = ( version >= 7500 ) ? reader.getUint64() : reader.getUint32(); | |||
| var propertyListLen = ( version >= 7500 ) ? reader.getUint64() : reader.getUint32(); | |||
There was a problem hiding this comment.
Why have you removed this line?
I don't think we should remove...
There was a problem hiding this comment.
Ah, probably you did that because propertyListLen is unused, correct?
But the line is necessary to move the pointer forward in the binary file.
There was a problem hiding this comment.
But the line is necessary to move the pointer forward in the binary file.
Sry guys! I've overlooked that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the code quality of most loaders. So minor things like better code style, added missing semicolons and correct spaces/indentations (according to Mr.doob's Code Style™).