Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ColladaLoader with ColladaLoader2 #12212

Merged
merged 2 commits into from Sep 17, 2017
Merged

Replace ColladaLoader with ColladaLoader2 #12212

merged 2 commits into from Sep 17, 2017

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 16, 2017

This PR removes the old ColladaLoader and replaces it with ColladaLoader2.

ColladaLoader2 supports the most important features in a much more efficient way. It uses BufferGeometry, it directly generates AnimationClip objects for skeletal animation and allocates less memory when parsing a dae file.

However, keyframe animations and morph target animations are not supported anymore. But I personally think the project should not invest more time in enhancing a Collada loader but focus on glTF. So if users are missing features, they can try to convert their files to glTF with COLLADA2GLTF.

If a community member would like to introduce more features to ColladaLoader, I will support as best as I can. Same for bug fixing. But still three.js as a project should generally recommend to use glTF wherever possible.

@looeee
Copy link
Collaborator

looeee commented Sep 16, 2017

But still three.js as a project should generally recommend to use glTF wherever possible.

I'd like to agree with you, but as far as I have been able to find there are hardly any glTF exporters, aside from the blender one which is far from easy to use. So 'wherever possible' so far means 'not in most cases'.

I haven't tried the Collada to glTF converter though, if that works well then I like the idea of recommending glTF instead of Collada, specifically. But I don't think it's quite ready to be recommended as the overall preferred format.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 16, 2017

I haven't tried the Collada to glTF converter though, if that works well then I like the idea of recommending glTF instead of Collada, specifically.

I've tested the converter with some models but it did not always produced correct output (see https://discourse.threejs.org/t/skinned-mesh-distorted-after-converting-to-gltf-from-dae/867). But as long as the developers fix the bugs, i'm okay with it.

@mrdoob mrdoob merged commit 1ae3d36 into mrdoob:dev Sep 17, 2017
@mrdoob
Copy link
Owner

mrdoob commented Sep 17, 2017

Thanks thanks!

@Mugen87 Mugen87 deleted the examples branch September 17, 2017 09:51
@Mugen87 Mugen87 mentioned this pull request Sep 17, 2017
@mrdoob
Copy link
Owner

mrdoob commented Sep 17, 2017

@Mugen87 If you want to make it even more robust, here's a bunch of samples from a previous attempt of re-doing ColladaLoader (sadly it was done in CoffeeScript):

https://github.com/rmx/threejs-collada/tree/master/testdata/3drt-monster

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 17, 2017

Interesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants