Replace ColladaLoader with ColladaLoader2 #12212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old
ColladaLoader
and replaces it withColladaLoader2
.ColladaLoader2
supports the most important features in a much more efficient way. It usesBufferGeometry
, it directly generatesAnimationClip
objects for skeletal animation and allocates less memory when parsing adae
file.However, keyframe animations and morph target animations are not supported anymore. But I personally think the project should not invest more time in enhancing a
Collada
loader but focus onglTF
. So if users are missing features, they can try to convert their files toglTF
with COLLADA2GLTF.If a community member would like to introduce more features to
ColladaLoader
, I will support as best as I can. Same for bug fixing. But stillthree.js
as a project should generally recommend to useglTF
wherever possible.