Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebVR: Update origin trial token #12607

Merged
merged 1 commit into from Nov 8, 2017
Merged

WebVR: Update origin trial token #12607

merged 1 commit into from Nov 8, 2017

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 8, 2017

New Tokens 馃帀 !

Important note: The tokens only work with Chrome M62+.

@mrdoob
Copy link
Owner

mrdoob commented Nov 8, 2017

Important note: The tokens only work with Chrome M62+.

Good to know!

@mrdoob mrdoob merged commit ea5139a into mrdoob:dev Nov 8, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 9, 2017

Hmm, how come not all the webvr examples use the tokens? 馃

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 9, 2017

see #11122

At that time we decided to exclude all Vive related stuff. But i think it should be no problem to add the token to all WebVR examples.

@mrdoob
Copy link
Owner

mrdoob commented Nov 9, 2017

Yeah, I think we should add it to all the examples. Otherwise, on Chrome/Android, some examples show ENTER VR and others show WEBVR NOT SUPPORTED.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 10, 2017

Okay 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants