Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clarify requestAnimationFrame speed #12641

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Docs: clarify requestAnimationFrame speed #12641

merged 1 commit into from
Nov 14, 2017

Conversation

Kos
Copy link
Contributor

@Kos Kos commented Nov 13, 2017

It's not strictly true that requestAnimationFrame runs at 60fps - it depends on the device.
Assuming 60fps will make your app misbehave on computers with 75hz or 144hz screens.
This is an early tutorial, but let's at least give an early heads up that there's a gotcha here.

It's not strictly true that requestAnimationFrame runs at 60fps - it depends on the device.
Assuming 60fps will make your app misbehave on computers with 75hz or 144hz screens.
This is an early tutorial, but let's at least give an early heads up that there's a gotcha here.
@Kos
Copy link
Contributor Author

Kos commented Nov 13, 2017

I'd look for a good place to provide example code how to avoid the problem by using the time parameter passed to requestAnimationFrame, do you think we should have this too in the docs? FAQ? separate page?

@looeee
Copy link
Collaborator

looeee commented Nov 14, 2017

I think that having a short tutorial titled "the render loop" in the getting started section of the manual would be a useful addition, since this programming pattern is used in nearly all three.js projects.

@mrdoob mrdoob merged commit dfff0c8 into mrdoob:dev Nov 14, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 14, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants