Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triangle: Rename methods #13549

Merged
merged 4 commits into from Mar 9, 2018
Merged

Triangle: Rename methods #13549

merged 4 commits into from Mar 9, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Mar 9, 2018 •
edited

see #13530 (comment)

Renames the following methods:

  • Triangle.area() to Triangle.getArea()
  • Triangle.barycoordFromPoint() to Triangle.getBarycoord()
  • Triangle.midpoint() to Triangle.getMidpoint()
  • Triangle.normal() to Triangle.getNormal()
  • Triangle.plane() to Triangle.getPlane()

@Mugen87 Mugen87 changed the title Triangle: Refactor methods Triangle: Rename methods Mar 9, 2018
@mrdoob mrdoob added this to the r91 milestone Mar 9, 2018
@mrdoob mrdoob merged commit 7e7f7fc into mrdoob:dev Mar 9, 2018
@mrdoob
Copy link
Owner

mrdoob commented Mar 9, 2018

Thanks!

@WestLangley WestLangley mentioned this pull request Apr 4, 2018
Closed
@Mugen87 Mugen87 mentioned this pull request May 12, 2018
Closed
13 tasks
@mqp mqp mentioned this pull request Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r91
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mugen87 @mrdoob