GLTFExporter: Support KHR_materials_unlit. #13566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
takahirox
reviewed
Mar 12, 2018
| // @QUESTION Should we avoid including any attribute that has the default value? | ||
| var gltfMaterial = { | ||
|
|
||
| pbrMetallicRoughness: {} | ||
|
|
||
| }; | ||
|
|
||
| if ( material instanceof THREE.MeshBasicMaterial ) { |
There was a problem hiding this comment.
Off topic:
@mrdoob If I'm right, Three.js recommends to use object.is* rather than instanceof for Three.js object, correct? If so, I'm gonna make PR to replace them because bunch of instanceof are used in GLTFExporter,
takahirox
reviewed
Mar 12, 2018
| } else if ( material instanceof THREE.MeshBasicMaterial ) { | ||
|
|
||
| gltfMaterial.pbrMetallicRoughness.metallicFactor = 0.0; | ||
| gltfMaterial.pbrMetallicRoughness.roughnessFactor = 0.9; |
There was a problem hiding this comment.
Where are these numbers 0.0 and 0.9 from?
There was a problem hiding this comment.
takahirox
approved these changes
Mar 12, 2018
|
@donmccurdy looking good! 🎉 🎉🎉🎉🎉 this is something I needed for apainter hehe |
fernandojsg
approved these changes
Mar 12, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @takahirox @fernandojsg