Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "ExtrudeGeometry: Remove option "frames""" #13705

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Mar 27, 2018

Reverts #13588

See #13587

@mrdoob mrdoob added this to the r92 milestone Mar 27, 2018
@mrdoob mrdoob merged commit 31503d8 into dev Mar 27, 2018
@mrdoob mrdoob deleted the revert-13588-revert-13587-dev7 branch March 27, 2018 20:54
@serenayl
Copy link
Contributor

I am trying to upgrade from a pre-r92 version, and am stuck on this one. Without custom "frames" in ExtrudeGeometry, is there another method we can use to orient our extruded shapes along the path?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 10, 2018

Please read #13587 (comment) and #13587 (comment)

@serenayl
Copy link
Contributor

@Mugen87 Thanks for your response! I will stick with r91 or clone the constructors for ExtrudeGeometry and ExtrudeBufferGeometry for my purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants