open code log2 replacement for IE11 compat #13714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
reviewed
Mar 28, 2018
src/renderers/webgl/WebGLTextures.js
Outdated
| @@ -93,7 +93,7 @@ function WebGLTextures( _gl, extensions, state, properties, capabilities, utils, | |||
| _gl.generateMipmap( target ); | |||
|
|
|||
| var textureProperties = properties.get( texture ); | |||
| textureProperties.__maxMipLevel = Math.log2( Math.max( width, height ) ); | |||
| textureProperties.__maxMipLevel = Math.log( Math.max( width, height ) ) * Math.LOG2E; | |||
There was a problem hiding this comment.
Personally I want comment here describing this style is for browsers which don't support Math.log2.
There was a problem hiding this comment.
Good point, I was intending to but forgot by the time I got to a keyboard.
Another + point for a polyfill, the workaround is contained in one place.
I'll add the comment
Mugen87
approved these changes
Mar 28, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative fix for IE11