Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtrudeGeometry: Removed index. #13780

Merged
merged 1 commit into from
Apr 7, 2018
Merged

ExtrudeGeometry: Removed index. #13780

merged 1 commit into from
Apr 7, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 5, 2018

@Mugen87 Mugen87 requested a review from WestLangley April 5, 2018 17:38
@mrdoob mrdoob added this to the r92 milestone Apr 6, 2018
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 7, 2018 •
edited
Loading

@WestLangley Is it okay for you to merge this? 😊

(I have another PR for ExtrudeGeometry in the pipeline based on these changes.)

WestLangley
WestLangley reviewed Apr 7, 2018
View reviewed changes
Copy link
Collaborator

@WestLangley WestLangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks OK to me. I have not tested it , though.

Unrelated: I think getArrays() should be private.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 7, 2018

Unrelated: I think getArrays() should be private.

Guess what my next PR is about 😁

@mrdoob mrdoob merged commit 02145fe into mrdoob:dev Apr 7, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WestLangley WestLangley WestLangley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r92
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mugen87 @mrdoob @WestLangley