Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Clean up #13852

Merged
merged 4 commits into from
Apr 13, 2018
Merged

Examples: Clean up #13852

merged 4 commits into from
Apr 13, 2018

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 13, 2018

Get rid of Geometry in some examples. Also minor clean up...

@looeee
Copy link
Collaborator

looeee commented Apr 13, 2018

Sweet! They're kind of misnamed now though - especially webgl_geometry_normals, since if you select, say, CircleGeometry from the menu it's actually displaying a CircleBufferGeometry.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 13, 2018

Good point. Let's change this 😊

@mrdoob mrdoob added this to the r92 milestone Apr 13, 2018
@mrdoob mrdoob merged commit c02ab35 into mrdoob:dev Apr 13, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants